lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9] Firmware: firmware_class, fix lock imbalance
    Date
    From: Jiri Slaby <jirislaby@gmail.com>

    Add omitted unlock in firmware_data_read.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/base/firmware_class.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
    index fc46653..f285f44 100644
    --- a/drivers/base/firmware_class.c
    +++ b/drivers/base/firmware_class.c
    @@ -217,8 +217,10 @@ firmware_data_read(struct kobject *kobj, struct bin_attribute *bin_attr,
    ret_count = -ENODEV;
    goto out;
    }
    - if (offset > fw->size)
    - return 0;
    + if (offset > fw->size) {
    + ret_count = 0;
    + goto out;
    + }
    if (count > fw->size - offset)
    count = fw->size - offset;

    --
    1.6.3.2


    \
     
     \ /
      Last update: 2009-07-13 00:51    [W:4.555 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site