lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] move omap_udc's probe function to .devinit.text
    On Sat, Jul 11, 2009 at 03:30:44PM -0700, David Brownell wrote:
    > On Saturday 11 July 2009, Uwe Kleine-König wrote:
    > > An alternative to this patch is using platform_driver_probe instead of
    > > platform_driver_register plus removing the pointer to the probe function
    > > from the struct platform_driver.
    >
    > Repeat -- NAK on this. Use platform_driver_probe() instead.
    Oh, I just noticed that this patch is a relict. The driver was changed
    to use platform_driver_probe in
    864e28b4f24106b799e991fa136fa6fa2b638a68.

    As my old patch just applied anyhow I didn't notice that.

    And I just found another similar problem.
    E.g. clevo_mail_led_probe is defined to live in .init.text and uses
    platform_driver_probe, but as it's referenced in the driver struct my
    script matched this file.

    (Is it wrong (wrong as in "worth to be fixed") to reference the probe
    function in the driver struct when platform_driver_probe is used? If so
    at least

    drivers/serial/msm_serial.c
    drivers/i2c/busses/i2c-imx.c

    are effected, too. Patches at

    http://news.gmane.org/find-root.php?group=gmane.linux.ports.arm.kernel&article=62319

    )

    The other patches are not affected.

    @Greg: Please just drop these two patches:

    [PATCH] move omap_udc's probe function to .devinit.text
    [PATCH] move leds-clevo-mail's probe function to .devinit.text

    Sorry for the unconvenience.

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-12 22:51    [W:3.615 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site