lkml.org 
[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] staging/otus: Move a dereference below a NULL test
On Sat, 11 Jul 2009, Jiri Slaby wrote:

> On 07/11/2009 09:51 AM, Julia Lawall wrote:
> > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> > --- a/drivers/staging/otus/wwrap.c
> > +++ b/drivers/staging/otus/wwrap.c
> > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
> > {
> > struct usbdrv_private *macp =
> > container_of(work, struct usbdrv_private, kevent);
> > - zdev_t *dev = macp->device;
> > + zdev_t *dev;
> >
> > if (macp == NULL)
> > {
> > return;
> > }
>
> The test is rather useless here.

OK, I will submit a revised patch that just drops it.

thanks,
julia

> > + dev = macp->device;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


\
 
 \ /
  Last update: 2009-07-11 10:35    [W:0.054 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site