lkml.org 
[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] move sb1250-mac's probe function to .devinit.text
    On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:

    > A pointer to sbmac_probe is passed to the core via
    > platform_driver_register and so the function must not disappear when the
    > .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    > unbinding and binding a device to the driver via sysfs will result in an
    > oops as does a device being registered late.
    >
    > An alternative to this patch is using platform_driver_probe instead of
    > platform_driver_register plus removing the pointer to the probe function
    > from the struct platform_driver.
    >
    > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
    > Cc: Weiwei Wang <weiwei.wang@windriver.com>
    > Cc: Jeff Garzik <jgarzik@redhat.com>
    > Cc: David S. Miller <davem@davemloft.net>
    > Cc: Stephen Hemminger <shemminger@vyatta.com>
    > Cc: Maciej W. Rozycki <macro@linux-mips.org>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > ---
    > drivers/net/sb1250-mac.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)

    Acked-by: Maciej W. Rozycki <macro@linux-mips.org>

    Fine by me, thanks.

    Maciej


    \
     
     \ /
      Last update: 2009-07-12 02:39    [W:0.022 / U:61.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site