lkml.org 
[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] move hp-wmi's probe function to .devinit.text
    Date
    A pointer to hp_wmi_bios_setup is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Frans Pop <elendil@planet.nl>
    Cc: Larry Finger <Larry.Finger@lwfinger.net>
    Cc: Len Brown <lenb@kernel.org>
    Cc: Helge Deller <deller@gmx.de>
    Cc: Matthew Garrett <mjg@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    drivers/platform/x86/hp-wmi.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
    index ca50856..f1f7090 100644
    --- a/drivers/platform/x86/hp-wmi.c
    +++ b/drivers/platform/x86/hp-wmi.c
    @@ -51,7 +51,7 @@ MODULE_ALIAS("wmi:5FB7F034-2C63-45e9-BE91-3D44E2C707E4");
    #define HPWMI_WIRELESS_QUERY 0x5
    #define HPWMI_HOTKEY_QUERY 0xc

    -static int __init hp_wmi_bios_setup(struct platform_device *device);
    +static int __devinit hp_wmi_bios_setup(struct platform_device *device);
    static int __exit hp_wmi_bios_remove(struct platform_device *device);
    static int hp_wmi_resume_handler(struct platform_device *device);

    @@ -425,7 +425,7 @@ static void cleanup_sysfs(struct platform_device *device)
    device_remove_file(&device->dev, &dev_attr_tablet);
    }

    -static int __init hp_wmi_bios_setup(struct platform_device *device)
    +static int __devinit hp_wmi_bios_setup(struct platform_device *device)
    {
    int err;
    int wireless = hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 0, 0);
    --
    1.6.3.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-11 23:05    [W:0.023 / U:30.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site