[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] move orion_nand's probe function to .devinit.text
    A pointer to orion_nand_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <>
    Cc: Lennert Buytenhek <>
    Cc: Saeed Bishara <>
    Cc: Jörn Engel <>
    Cc: Nicolas Pitre <>
    Cc: Tzachi Perelstein <>
    Cc: Andrew Morton <>
    drivers/mtd/nand/orion_nand.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
    index 7ad9722..748112c 100644
    --- a/drivers/mtd/nand/orion_nand.c
    +++ b/drivers/mtd/nand/orion_nand.c
    @@ -69,7 +69,7 @@ static void orion_nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
    buf[i++] = readb(io_base);

    -static int __init orion_nand_probe(struct platform_device *pdev)
    +static int __devinit orion_nand_probe(struct platform_device *pdev)
    struct mtd_info *mtd;
    struct nand_chip *nc;
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-07-11 23:05    [W:0.026 / U:0.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site