lkml.org 
[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] move xtsonic's probe function to .devinit.text
    Date
    A pointer to xtsonic_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Chris Zankel <chris@zankel.net>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    drivers/net/xtsonic.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/xtsonic.c b/drivers/net/xtsonic.c
    index 5a4ad15..0c44135 100644
    --- a/drivers/net/xtsonic.c
    +++ b/drivers/net/xtsonic.c
    @@ -239,7 +239,7 @@ out:
    * Actually probing is superfluous but we're paranoid.
    */

    -int __init xtsonic_probe(struct platform_device *pdev)
    +int __devinit xtsonic_probe(struct platform_device *pdev)
    {
    struct net_device *dev;
    struct sonic_local *lp;
    --
    1.6.3.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-11 22:59    [W:0.022 / U:30.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site