lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] Fix sysrq caused USB performance regressions and leak
On 2009-07-10 02:01:37, Alan Cox wrote:
> > shouldn't it be
> > + if (likely(!port->console || !port->sysrq))
> > respectively
> > + if (unlikely(port->console && port->sysrq)) {
> >
> > at least for clarity?
>
> It'll get predicted by the CPU just fine I suspect.

I thought likely() / unlikely() were for the _compiler_ to arrange the
blocks more efficiently?

Anders



\
 
 \ /
  Last update: 2009-07-10 11:11    [W:0.072 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site