Messages in this thread | | | Date | Fri, 10 Jul 2009 11:07:53 +0200 | From | Anders Larsen <> | Subject | Re: [PATCH 0/3] Fix sysrq caused USB performance regressions and leak |
| |
On 2009-07-10 02:01:37, Alan Cox wrote: > > shouldn't it be > > + if (likely(!port->console || !port->sysrq)) > > respectively > > + if (unlikely(port->console && port->sysrq)) { > > > > at least for clarity? > > It'll get predicted by the CPU just fine I suspect.
I thought likely() / unlikely() were for the _compiler_ to arrange the blocks more efficiently?
Anders
| |