lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] kernel.printk.c - ensure that "console enabled"messages are printed on the console
Date
On Fri 10 Jul 2009 06:25, Ingo Molnar pondered:
>
> * Robin Getz <rgetz@blackfin.uclinux.org> wrote:
>
> > From: Robin Getz <rgetz@blackfin.uclinux.org>
> >
> > Today, when a console is registered without CON_PRINTBUFFER, end
> > users never see the announcement of it being added, and never know
> > if they missed something, if the console is really at the start or
> > not, and just leads to general confusion.
> >
> > This re-orders existing code, to make sure the console is added,
> > before the "console [%s%d] enabled" is printed out - ensuring that
> > this message is _always_ seen.
> >
> > This has the desired/intended side effect of making sure that
> > "console enabled:" messages are printed on the bootconsole, and
> > the real console. This does cause the same line is printed twice
> > if the bootconsole and real console are the same device, but if
> > they are on different devices, the message is printed to both
> > consoles.
> >
> > Signed-off-by : Robin Getz <rgetz@blackfin.uclinux.org>
> >
> > ---
> >
> > printk.c | 44 +++++++++++++++++++++++++++++---------------
> > 1 file changed, 29 insertions(+), 15 deletions(-)
> >
> > patch generated for -tip
>
> Looks good, applied it to tip:core/printk for v2.6.32, thanks Robin.
>
> i fixed a couple of small details in the patch:
>
> - re-broke the commit log as it was too wide for nice git log
> output

Hmm - I didn't know there was a restriction on this - what is the number?

> - fixed a stray whitespace warned about by scripts/checkpatch.pl
> - fixed another stray whitespace found the old fashioned way
> - fixed the patch title to match the prefix used by your previous
> commit as well

Thanks
-Robin


\
 
 \ /
  Last update: 2009-07-10 16:13    [W:0.127 / U:2.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site