lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] This is the security processor driver for the Intel mid platform

> + *
> + * CHANGES:
> + *
> + * 2009.06.26 Initial publish
> + *
> + */

No changelogs in source files, please...

> +
> + /* start address of resident */

Eh?

> + unsigned long message_size_in_words;
> +
> +};

> +struct sep_driver_realloc_cache_resident_t {
> + /* base address */
> + unsigned long base_addr;

Most useless comment, ever.

> + /* cache size in bytes*/
> + unsigned long cache_size_in_bytes;

...and more.

> + /* new resident address */
> + unsigned long new_resident_addr;
> +
> + /* new resident address */
> + unsigned long new_shared_area_addr;

Ouch. Copy & paste error?

> + /* new base address */
> + unsigned long new_base_addr;

Did they tell you you have to document it, so you did? Bad comments
are worse than no comments...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-07-10 14:11    [W:0.043 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site