lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][cpufreq][Powernow-k8] support family 0xf with 2 low p-states
From
Date
On Thu, 2009-07-02 at 14:15 -0700, Andrew Morton wrote:
> On Sun, 26 Jul 2009 10:55:25 -0500
> Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> >
> > Subject: [PATCH][cpufreq][Powernow-k8] support family 0xf with 2 low p-states
>
> Please leave the subsystem identification text outside the [].
> Documentation/SubmittingPatches section 15 has details.
>
>
> > --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> > +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.h
> > @@ -215,7 +215,8 @@ struct pst_s {
> >
> > #define dprintk(msg...) cpufreq_debug_printk(CPUFREQ_DEBUG_DRIVER, "powernow-k8", msg)
> >
> > -static int core_voltage_pre_transition(struct powernow_k8_data *data, u32 reqvid);
> > +static int core_voltage_pre_transition(struct powernow_k8_data *data,
> > + u32 reqvid, u32 regfid);
> > static int core_voltage_post_transition(struct powernow_k8_data *data, u32 reqvid);
> > static int core_frequency_transition(struct powernow_k8_data *data, u32 reqfid);
>
> It's fairly dopey to have static function declarations in a header file
> - no other .c fail can _use_ them, so they may as well be tucked away

hehe, FAIL, hehe ;-)

> inside their .c file. And that's only needed if the functions indeed
> need to be forward-declared.



\
 
 \ /
  Last update: 2009-07-10 12:07    [W:0.025 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site