lkml.org 
[lkml]   [2009]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH -tip] x86: amd_iommu.c device_nb should be static
    From
    Date

    This sparse warning:

    arch/x86/kernel/amd_iommu.c:1195:23: warning: symbol 'device_nb' was not declared. Should it be static?

    triggers because device_nb is global but is only used in a single .c file.
    change device_nb to static to fix that - this also address the sparse warning.

    This sparse warning:

    arch/x86/kernel/amd_iommu.c:1766:10: warning: Using plain integer as NULL pointer

    triggers because plain integer 0 is used inplace of NULL pointer.
    change 0 to NULL to fix that - this also address the sparse warning.

    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    ---
    arch/x86/kernel/amd_iommu.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
    index 9372f04..6c99f50 100644
    --- a/arch/x86/kernel/amd_iommu.c
    +++ b/arch/x86/kernel/amd_iommu.c
    @@ -1192,7 +1192,7 @@ out:
    return 0;
    }

    -struct notifier_block device_nb = {
    +static struct notifier_block device_nb = {
    .notifier_call = device_change_notifier,
    };

    @@ -1763,7 +1763,7 @@ static void *alloc_coherent(struct device *dev, size_t size,
    flag |= __GFP_ZERO;
    virt_addr = (void *)__get_free_pages(flag, get_order(size));
    if (!virt_addr)
    - return 0;
    + return NULL;

    paddr = virt_to_phys(virt_addr);

    --
    1.6.0.6




    \
     
     \ /
      Last update: 2009-07-01 16:27    [W:0.033 / U:30.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site