lkml.org 
[lkml]   [2009]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip RESEND] x86: amd_iommu.c device_nb should be static

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

>
> device_nb is used only by same file, it should be static.
>
> Also fixed NULL pointer issue.
>
> Fixed following sparse warnings :
> arch/x86/kernel/amd_iommu.c:1195:23: warning: symbol 'device_nb' was not declared. Should it be static?
> arch/x86/kernel/amd_iommu.c:1766:10: warning: Using plain integer as NULL pointer

Mind resending this with a proper changelog, along the template of:

| This Sparse warning:
|
| arch/x86/kernel/amd_iommu.c...
|
| triggers because <reason>. <do action> to fix that - this also
| addresses the Sparse warning.

Where, in this current case:

<reason> := device_nb is global but is only used in a single .c file
<do action> := change device_nb to static

Please fill in the reason and action for the NULL fix as well.

Please write all similar warning fix commit log messages in a
similar way in the future if you want me to apply them.

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-07-01 15:25    [W:0.039 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site