Messages in this thread | | | Date | Wed, 1 Jul 2009 11:30:15 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] kmemleak: Fix scheduling-while-atomic bug |
| |
* Catalin Marinas <catalin.marinas@arm.com> wrote:
> > The minimal fix below removes scan_yield() and adds a > > cond_resched() to the outmost (safe) place of the scanning > > thread. This solves the regression. > > With CONFIG_PREEMPT disabled it won't reschedule during the bss > scanning but I don't see this as a real issue (task stacks > scanning probably takes longer anyway).
Yeah. I suspect one more cond_resched() could be added - i just didnt see an obvious place for it, given that scan_block() is being called with asymetric held-locks contexts.
Ingo
| |