lkml.org 
[lkml]   [2009]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] tracing/events: modify irq print to new format

On Wed, 10 Jun 2009, Frederic Weisbecker wrote:
> >
> > /**
> > @@ -106,8 +106,8 @@ TRACE_EVENT(softirq_entry,
> > __entry->vec = (int)(h - vec);
> > ),
> >
> > - TP_printk("softirq=%d action=%s", __entry->vec,
> > - show_softirq_name(__entry->vec))
> > + TP_FORMAT("softirq=<int:vec> action=<sym:vec:" show_softirq_name_format(),
>
>
> Just to zap the confusion, I would suggest to explicitly close the '>' here instead
> of inside the macro. The current state suggests a kind of imbalance at a first glance.
>
>
> > + show_softirq_name_args())
> > );
> >
> > /**
> > @@ -135,8 +135,8 @@ TRACE_EVENT(softirq_exit,
> > __entry->vec = (int)(h - vec);
> > ),
> >
> > - TP_printk("softirq=%d action=%s", __entry->vec,
> > - show_softirq_name(__entry->vec))
> > + TP_FORMAT("softirq=<int:vec> action=<sym:vec:" show_softirq_name_format(),
>
>
> And ditto.
>

Ah, yeah right. Now that I have the formats separated, I can do that. The
first patch had it as one (format and args). I'll add a separate patch in
my next set of patches that build on top of this one.

-- Steve



\
 
 \ /
  Last update: 2009-06-10 00:49    [W:0.040 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site