lkml.org 
[lkml]   [2009]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH block#for-2.6.31] block: add request clone interface
On Tue, Jun 09 2009, Kiyoshi Ueda wrote:
> Hi Jens,
>
> +/*
> + * Copy request information of the original request to the clone request.
> + */
> +static void __blk_rq_prep_clone(struct request *dst, struct request *src)
> +{
> + dst->cpu = src->cpu;
> + dst->cmd_flags = (rq_data_dir(src) | REQ_NOMERGE);
> + dst->cmd_type = src->cmd_type;
> + dst->__sector = blk_rq_pos(src);
> + dst->__data_len = blk_rq_bytes(src);
> + dst->nr_phys_segments = src->nr_phys_segments;
> + dst->ioprio = src->ioprio;
> + dst->buffer = src->buffer;
> + dst->cmd_len = src->cmd_len;
> + dst->cmd = src->cmd;

Are you making sure that 'src' always exists while 'dst' is alive?

--
Jens Axboe



\
 
 \ /
  Last update: 2009-06-09 20:07    [W:0.065 / U:7.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site