Messages in this thread | | | Date | Tue, 9 Jun 2009 18:07:38 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 8/8] imx: serial: add IrDA support to serial driver |
| |
> Sure, the path will be optimized away, but still > the conditional statement is subjected to syntax > and scope analysis and gcc will correctly complain > that irda_inv_rx is not declared.
Why are only about half of them done this way rather than all ?
> peripheral register settings, because the old baud rate > calculation was not accurate enough for IrDA use. > That's why we introduced the approximation function > (and finally generalised it into lib/).
Yes - I'm fine with that part.
Alan
| |