lkml.org 
[lkml]   [2009]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of =


On Tue, 9 Jun 2009, Dave Jones wrote:
>
> work_on_cpu()'s definition could probably use a fat comment describing
> why it sucks.

No, it should be renamed.

The problem is that it _sounds_ like a nice thing to do.

If it was called "slow_other_cpu_thread_switch_with_a_donkey_on_top()", I
bet people wouldn't be so damn eager to use it.

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.287 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site