Messages in this thread | | | Date | Tue, 9 Jun 2009 09:41:08 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of = |
| |
On Tue, 9 Jun 2009, Dave Jones wrote: > > work_on_cpu()'s definition could probably use a fat comment describing > why it sucks.
No, it should be renamed.
The problem is that it _sounds_ like a nice thing to do.
If it was called "slow_other_cpu_thread_switch_with_a_donkey_on_top()", I bet people wouldn't be so damn eager to use it.
Linus
| |