lkml.org 
[lkml]   [2009]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of =
On Tue, Jun 09, 2009 at 08:46:44AM -0700, Linus Torvalds wrote:

> Please STOP USING THAT HORRIBLE "work_on_cpu()" crap.
>
> Is there any reason you do that? We've had to fix up the fallout from that
> kind of crazy crap several times.
>
> Just use a regular IPI. Use "smp_call_function_[single|many]()" instead.
>
> See for example commit 01599fca6758d2cd133e78f87426fc851c9ea725, where
> another "work_on_cpu()" thing was broken.
>
> I don't understand why you guys keep on using that _known_ bad function.
> The whole point of "work_on_cpu()" is for big, slow, and rare things. Not
> as a random "let's make that CPU do this".
>
> So stop it.

work_on_cpu()'s definition could probably use a fat comment describing
why it sucks.


Dave



\
 
 \ /
  Last update: 2009-06-09 18:39    [W:0.197 / U:1.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site