Messages in this thread | | | Subject | Re: [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer | From | Huang Ying <> | Date | Mon, 08 Jun 2009 15:30:22 +0800 |
| |
On Mon, 2009-06-08 at 15:20 +0800, Ingo Molnar wrote: > * Huang Ying <ying.huang@intel.com> wrote: > > > Re-implement MCE log ring buffer as per-CPU ring buffer for better > > scalability. > > this should be done using the generic ring-buffer code - see > include/linux/ring_buffer.h. Having a private implementation in > architecture code is not really acceptable.
MCE log ring buffer need to be NMI-safe, while current generic ring-buffer code is not NMI safe. Maybe we can use the generic ring-buffer code after it goes NMI-safe. But for now, I think this patch is better.
Best Regards, Huang Ying
| |