[lkml]   [2009]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] perf_counter: extensible perf_counter_attr

    * Corey Ashford <> wrote:

    > Peter Zijlstra wrote:
    >> On Mon, 2009-06-08 at 14:18 -0700, Corey Ashford wrote:
    >>> pca.ext_attrs = &feature.head; /* secretly know that there's data
    >>> that lies past the attr struct header */
    >> Right, except its not so very secret since we have the type field
    >> telling us.
    > I see. Thanks for the explanation. Looks like a good plan to me!

    i think we'd have a much simpler implementation by changing
    __reserved_1 to attr_size. When the kernel adds new attributes, the
    size will increase - old user-space will use the old size which the
    kernel detects and adopts to (by zeroing out that attribute space).

    That way we'll always have a nice flat attributes structure, with no
    quirky chaining that has field-dependent data types ...


     \ /
      Last update: 2009-06-08 23:53    [W:0.033 / U:42.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site