lkml.org 
[lkml]   [2009]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] nfnetlink_queue: Use rcu_barrier() on module unload.
    On Mon, Jun 08, 2009 at 03:11:33PM +0200, Jesper Dangaard Brouer wrote:
    > This module uses rcu_call() thus it should use rcu_barrier() on module unload.
    >
    > Also fixed a trivial typo 'nfetlink' -> 'nfnetlink' in comment.

    Assuming that netlink_unregister_notifier(), nfnetlink_subsys_unregister(),
    and so on prevent any subsequent calls to call_rcu(), looks good!!!

    Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

    > Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
    > ---
    >
    > net/netfilter/nfnetlink_queue.c | 4 +++-
    > 1 files changed, 3 insertions(+), 1 deletions(-)
    >
    > diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
    > index 8c86011..71daa09 100644
    > --- a/net/netfilter/nfnetlink_queue.c
    > +++ b/net/netfilter/nfnetlink_queue.c
    > @@ -1,6 +1,6 @@
    > /*
    > * This is a module which is used for queueing packets and communicating with
    > - * userspace via nfetlink.
    > + * userspace via nfnetlink.
    > *
    > * (C) 2005 by Harald Welte <laforge@netfilter.org>
    > * (C) 2007 by Patrick McHardy <kaber@trash.net>
    > @@ -932,6 +932,8 @@ static void __exit nfnetlink_queue_fini(void)
    > #endif
    > nfnetlink_subsys_unregister(&nfqnl_subsys);
    > netlink_unregister_notifier(&nfqnl_rtnl_notifier);
    > +
    > + rcu_barrier(); /* Wait for completion of call_rcu()'s */
    > }
    >
    > MODULE_DESCRIPTION("netfilter packet queue handler");
    >


    \
     
     \ /
      Last update: 2009-06-08 18:09    [W:0.021 / U:29.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site