Messages in this thread | | | Date | Mon, 08 Jun 2009 11:09:52 +0200 | From | Stefan Richter <> | Subject | Re: [TRIVIAL][PATCH 1/1] Fix warning in staging/otus/ioctl.c |
| |
Pranith Kumar wrote: > @@ -629,7 +629,7 @@ void update_os_packet_info( > pOSPkt->dev = get_netdev_from_bssid(pAd, FromWhichBSSID); > pOSPkt->data = pRxBlk->pData; > pOSPkt->len = pRxBlk->DataSize; > - pOSPkt->tail = pOSPkt->data + pOSPkt->len; > + pOSPkt->tail = (UCHAR *) (pOSPkt->data + pOSPkt->len); > } > >
This is what I meant with "a warning should stay there as long as the underlying problem isn't fixed".
This code uses defined types which are foreign to Linux. We don't define UCHAR in Linux. /This/ needs to be fixed in the entire driver. Until this is not done, there is no reason to add this pointer type cast merely to quieten gcc. -- Stefan Richter -=====-==--= -==- -=--- http://arcgraph.de/sr/
| |