lkml.org 
[lkml]   [2009]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] integrity: fix IMA inode leak
From
Date
On Sat, 2009-06-06 at 21:18 +0100, Hugh Dickins wrote:
> CONFIG_IMA=y inode activity leaks iint_cache and radix_tree_node objects
> until the system runs out of memory. Nowhere is calling ima_inode_free()
> a.k.a. ima_iint_delete(). Fix that by calling it from destroy_inode().
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>

This call was accidentally dropped in the conversion from
using the LIM hooks to embedding the IMA calls directly. I'm
really sorry.

Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com>

> ---
>
> fs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- 2.6.30-rc8/fs/inode.c 2009-05-16 10:26:15.000000000 +0100
> +++ linux/fs/inode.c 2009-06-06 17:41:21.000000000 +0100
> @@ -219,6 +219,7 @@ static struct inode *alloc_inode(struct
> void destroy_inode(struct inode *inode)
> {
> BUG_ON(inode_has_buffers(inode));
> + ima_inode_free(inode);
> security_inode_free(inode);
> if (inode->i_sb->s_op->destroy_inode)
> inode->i_sb->s_op->destroy_inode(inode);



\
 
 \ /
  Last update: 2009-06-07 08:11    [from the cache]
©2003-2011 Jasper Spaans