lkml.org 
[lkml]   [2009]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 07/11] ACPI: acpi_pci_unbind should clean up properly after acpi_pci_bind
    Alex Chiang wrote:
    > * Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>:
    >>>
    >> I have a concern about this change.
    >>
    >> The acpi_pci_irq_del_prt() against dev->bus removes not only
    >> the _PRT entries for PCI function corresponding to specified
    >> acpi_device, but also other _PRT entries for working PCI
    >> devices/functions on the same bus. As a result, interrupt
    >> initialization for those PCI functions would no longer work
    >> properly after that.
    >>
    >> So I think we should not call acpi_pci_irq_del_prt() against
    >> dev->bus.
    >
    > Thanks for the review. I agree with you.
    >
    > Here is a respun version of this patch.
    >
    > From: Alex Chiang <achiang@hp.com>
    >
    > ACPI: acpi_pci_unbind should clean up properly after acpi_pci_bind
    >
    > In acpi_pci_bind, we set device->ops.bind and device->ops.unbind, but
    > never clear them out.
    >
    > Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
    > Signed-off-by: Alex Chiang <achiang@hp.com>
    > ---
    > diff --git a/drivers/acpi/pci_bind.c b/drivers/acpi/pci_bind.c
    > index 62cb383..c9cc650 100644
    > --- a/drivers/acpi/pci_bind.c
    > +++ b/drivers/acpi/pci_bind.c
    > @@ -109,11 +109,13 @@ static int acpi_pci_unbind(struct acpi_device *device)
    > struct pci_dev *dev;
    >
    > dev = acpi_get_pci_dev(device->handle);
    > - if (!dev)
    > + if (!dev || !dev->subordinate)
    > return 0;

    This would leak the pci_dev's refcount
    if dev != NULL && dev->subordinate == NULL.

    Thanks,
    Kenji Kaneshige


    >
    > - if (dev->subordinate)
    > - acpi_pci_irq_del_prt(dev->subordinate);
    > + acpi_pci_irq_del_prt(dev->subordinate);
    > +
    > + device->ops.bind = NULL;
    > + device->ops.unbind = NULL;
    >
    > pci_dev_put(dev);
    > return 0;
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    >
    >




    \
     
     \ /
      Last update: 2009-06-08 05:25    [W:7.326 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site