[lkml]   [2009]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [git pull] IDE fixes
On Sunday 07 June 2009 16:38:56 James Bottomley wrote:
> On Sun, 2009-06-07 at 15:21 +0100, Alan Cox wrote:
> > > diff --git a/fs/partitions/check.c b/fs/partitions/check.c
> > > index 99e33ef..4bc2c43 100644
> > > --- a/fs/partitions/check.c
> > > +++ b/fs/partitions/check.c
> >
> >
> > You seriously want to add code to the core partition handling logic
> > moments before release when we know we have all sorts of devices with
> > weird behaviours ?
> >
> > This should be .31 stuff where we can take the time to see how it works
> > on all sorts of weird real world devices (eg those with 2K sector size)
> > and the like.
> Absolutely seconded.
> Plus this is only one of the proposals for dealing with IDE native sizes
> moving through the process. The other one is in libata with the gendisk
> proposal for alt size instead of your set_capacity callback. The last

->set_capacity callback is needed for drivers/ide regardless of alt_size
sysfs interface and it don't conflict with it in any way.

Those patches are a complimentary work to Tejun's alt_size patches.

They don't export anything to user-space.

> thing we want is two separate mechanisms for this, so trying to push
> anything upstream before we have agreement on direction is premature ...
> trying to send a feature as a bug fix is doubly so.

James, please (re-)read commits, then bug #13365 at and if you
still find some code parts controversial I'll be happy to discuss them.


 \ /
  Last update: 2009-06-07 16:55    [W:0.056 / U:2.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site