lkml.org 
[lkml]   [2009]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND]X86:microcode: fix vfree()

* Figo.zhang <figo1802@gmail.com> wrote:

> On Sun, 2009-06-07 at 16:21 +0200, Ingo Molnar wrote:
> > (Note: it's not a 'resend', it's v2 of the patch)
> >
> > * Figo.zhang <figo1802@gmail.com> wrote:
> >
> > > vfree() does its own 'NULL' check, so no need for check before
> > > calling it.
> > >
> > > Signed-off-by: Figo.zhang <figo1802@gmail.com>
> > > ---
> > > arch/x86/kernel/microcode_amd.c | 13 +++++--------
> > > 1 files changed, 5 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
> > > index 453b579..8f52cf4 100644
> > > --- a/arch/x86/kernel/microcode_amd.c
> > > +++ b/arch/x86/kernel/microcode_amd.c
> > > @@ -257,10 +257,9 @@ static int install_equiv_cpu_table(const u8 *buf)
> > >
> > > static void free_equiv_cpu_table(void)
> > > {
> > > - if (equiv_cpu_table) {
> > > - vfree(equiv_cpu_table);
> > > - equiv_cpu_table = NULL;
> > > - }
> > > + vfree(equiv_cpu_table);
> > > + equiv_cpu_table = NULL;
> > > +
>
> i motify by vim, you said this line?

yes, that extra empty newline should not be there. (i.e. the line
should be removed)

Ingo


\
 
 \ /
  Last update: 2009-06-07 16:31    [W:0.039 / U:5.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site