lkml.org 
[lkml]   [2009]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kmemcheck: make bitfield annotations be valid C
On Sun, Jun 07, 2009 at 11:20:54AM +0200, Ingo Molnar wrote:
> > > > According to Al Viro, the syntax we were using (putting #ifdef inside
> > > > macro arguments) was not valid C. He also suggested using begin/end
> > > > markers instead, which is what we do now.
> > > >
> > > > Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> > > > Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> > >
> > > Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> > >
> > > Al, are you okay with this?
> >
> > Looks sane
>
> Thanks.
>
> This removes the blocker bug from kmemcheck and we can try to push
> it in the .31 merge window. Does the level and amount of bit-field
> annotations look unduly troublesome to you? If we merge kmemcheck
> then we'll have these type annotations forever.

What had been posted in this thread didn't look over the top for me, but
it's really a question for maintainers of the affected code...


\
 
 \ /
  Last update: 2009-06-07 15:09    [W:0.025 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site