[lkml]   [2009]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: add bcm47xx watchdog driver
Le Friday 05 June 2009 16:58:42, vous avez écrit :
> Hi Florian,
> Quoting Florian Fainelli <>:
> > Your driver looks good, could you turn this into a platform device/driver
> > instead ? You declare bcm47xx_wdt_platform_device which is unused and you
> > also declare a MODULE_ALIAS which suggets it is one.
> What's the advantage of using platform device/driver ?
> Not all watchdog driver use it (for example softdog).
> This seems useless in this case because the driver don't have any resource,
> don't care about suspend/resume and add complexity in the code (2 registers
> in module probe, ...).

Indeed, I was suggesting that either you turn it into a full platform driver
or your remove references to it (bcm47xx_wdt_platform_device and
Best regards, Florian Fainelli
Email :
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2009-06-06 13:01    [W:0.052 / U:2.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site