lkml.org 
[lkml]   [2009]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectSolution: N810 keyboard regression
Date
Found the problem with the 2.6.29 N810 keyboard regression in this commit:
commit c83702a764c3099df50f215b8e79e07344e34a1a
Author: Felipe Balbi <felipe.balbi@nokia.com>
Date: Thu Feb 19 12:29:40 2009 +0000
input: lm8323: get rid of useless debug macro
we can use dev_vdbg() which is only true when VERBOSE is enabled.

Part of this commit removed the "default" values for platform parameters, but
set the N810's size_y to 8 instead of the earlier default of 12. Changing this
to 12 (patch to follow) fixes the keyboard regression. Note, the total keys on
the N810 is in fact under 64, so 8x8 seems correct. Not sure why it doesn't
work like that in practise. I did notice a curious line in the driver that
might (or might not) be related/wrong...

drivers/input/keyboard/lm8323.c line 353:
int keysize = (lm->size_x << 4) | lm->size_y;

Shouldn't this be lm->size_x * lm->size_y?

Luke


\
 
 \ /
  Last update: 2009-06-07 00:03    [W:0.032 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site