lkml.org 
[lkml]   [2009]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] perf-top: Wait for a minimal set of events before reading first snapshot
Date
The first snapshot reading often occur before any events have been
read in the mapped perfcounter files.

Just wait until we have at least one event before starting the
snapshot, or the delay before the first set of entries to be
displayed may be long in case of low refresh rate.

Note: we could also use a semaphore to wait before "print_entries"
number of eveents is reached, but again this value is tunable
and we can't ensure we will even reach it. Also we could base
on a default mimimum set of entries for the first refresh, say 15,
but again, the minimal sample is tunable, and we could end up
displaying nothing until we have a minimal default set of events,
which can take some time in case of high samples filters.

Hence this simple solution which partially covers the default case.

[ Impact: display first events once they are available on perf top ]

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbeec@gmail.com>
---
tools/perf/builtin-top.c | 22 +++++++++++++++++-----
1 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index f2e7312..fdc1d58 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -420,7 +420,7 @@ static unsigned int mmap_read_head(struct mmap_data *md)

struct timeval last_read, this_read;

-static void mmap_read(struct mmap_data *md)
+static void mmap_read_counter(struct mmap_data *md)
{
unsigned int head = mmap_read_head(md);
unsigned int old = md->prev;
@@ -517,6 +517,16 @@ static void mmap_read(struct mmap_data *md)
static struct pollfd event_array[MAX_NR_CPUS * MAX_COUNTERS];
static struct mmap_data mmap_array[MAX_NR_CPUS][MAX_COUNTERS];

+static void mmap_read(void)
+{
+ int i, counter;
+
+ for (i = 0; i < nr_cpus; i++) {
+ for (counter = 0; counter < nr_counters; counter++)
+ mmap_read_counter(&mmap_array[i][counter]);
+ }
+}
+
static int __cmd_top(void)
{
struct perf_counter_attr *attr;
@@ -571,6 +581,11 @@ static int __cmd_top(void)
}
}

+ /* Wait for a minimal set of events before starting the snapshot */
+ poll(event_array, nr_poll, 100);
+
+ mmap_read();
+
if (pthread_create(&thread, NULL, display_thread, NULL)) {
printf("Could not create display thread.\n");
exit(-1);
@@ -589,10 +604,7 @@ static int __cmd_top(void)
while (1) {
int hits = samples;

- for (i = 0; i < nr_cpus; i++) {
- for (counter = 0; counter < nr_counters; counter++)
- mmap_read(&mmap_array[i][counter]);
- }
+ mmap_read();

if (hits == samples)
ret = poll(event_array, nr_poll, 100);
--
1.6.2.3


\
 
 \ /
  Last update: 2009-06-06 23:13    [W:0.065 / U:2.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site