lkml.org 
[lkml]   [2009]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [sound] mpd loops on current -next
On Sat, 6 Jun 2009, Jiri Slaby wrote:

> Hi,
>
> I found a regression in current -next caused by
> c44941e05900fe85f6091456f9e313b446a97ae9
> (PCM midlevel: Do not update hw_ptr_jiffies when hw_ptr is not changed)

Oops. It seems like typo. Could you try this patch, please?

diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index dd9126b..bf34603 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -371,7 +371,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm_substream *substream)
runtime->silence_size > 0)
snd_pcm_playback_silence(substream, new_hw_ptr);

- if (runtime->status->hw_ptr != new_hw_ptr)
+ if (runtime->status->hw_ptr == new_hw_ptr)
return 0;

runtime->hw_ptr_base = hw_base;
Thanks,
Jaroslav

-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.


\
 
 \ /
  Last update: 2009-06-06 18:17    [from the cache]
©2003-2011 Jasper Spaans