lkml.org 
[lkml]   [2009]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 17/39] kbuild: fix header export when __ASSEMBLY__ is used
    On Sat, Jun 06, 2009 at 12:41:07AM +0000, Arnd Bergmann wrote:
    > On Friday 05 June 2009 11:42:35 pm Sam Ravnborg wrote:
    > > Because it does not know __ASSEMBLY__ it does not
    > > detect that htis is not for userspace.
    > > This caused too much code to be exported, and headers_check barfed
    > > over this code.
    > >
    > > For arm this fixes following "make headers_check" warning:
    > > /usr/include/asm/hwcap.h:29: extern's make no sense in userspace
    >
    > Are you sure that this is safe for all user space? If a user application
    > for instance includes asm/signal.h or asm/types.h from assembly (for
    > whatever reason), it now breaks.

    I had not thought about this implication.
    I will drop the patch as this most likely
    will break some userspace.

    Sam


    \
     
     \ /
      Last update: 2009-06-06 08:07    [W:4.305 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site