lkml.org 
[lkml]   [2009]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] headers_check fix: arm, hwcap.h
    On Thu, Jun 04, 2009 at 10:16:49PM +0200, Sam Ravnborg wrote:
    > On Thu, Jun 04, 2009 at 01:53:07PM +0100, Russell King wrote:
    > > On Thu, Jun 04, 2009 at 05:57:56PM +0530, Jaswinder Singh Rajput wrote:
    > > > fix the following 'make headers_check' warning:
    > >
    > > I think headers_check needs fixing - there's nothing wrong with the
    > > code as it presently stands except the tools obviously can't properly
    > > parse C preprocessor statements.
    >
    > You are correct that headers_ceck is limited here and this patch
    > take some valid code and refactor it to make it headers_check compatible.

    If it is just a matter of unifdef not doing the right thing, then that's
    a bug in unifdef - looking at the code, it _should_ handle the case as
    it's currently in the tree.

    I'll spend a bit looking at this issue before applying this patch - if
    the fix turns out to be trivial then we all win by not requiring people
    to write stuff in unexpected (to the tools, but standard C) ways.

    --
    Russell King
    Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
    maintainer of:


    \
     
     \ /
      Last update: 2009-06-05 22:15    [W:0.023 / U:2.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site