Messages in this thread | | | Date | Fri, 5 Jun 2009 21:22:06 +0200 | From | Christoph Hellwig <> | Subject | Re: [this_cpu_xx 07/11] xfs_icsb_modify_counters does not need "cpu" variable |
| |
On Fri, Jun 05, 2009 at 03:18:26PM -0400, cl@linux-foundation.org wrote: > The xfs_icsb_modify_counters() function no longer needs the cpu variable > if we use this_cpu_ptr() and we can get rid of get/put_cpu().
Looks good to me. While you're at it you might also remove the superflous cast of the this_cpu_ptr return value.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, any reason this_cpu_ptr doesn't do the preempt_disable itself and has something paired to reverse it?
| |