Messages in this thread Patch in this message | | | Date | Fri, 5 Jun 2009 11:26:37 +0200 | From | Michał Mirosław <> | Subject | Re: [PATCH 2.6.29.4] Driver for CB710/720 memory card reader (MMC part) - v5 fixed |
| |
cb710: Fix compilation warnings
Fix compilation warnings reported by Stephen Rothwell and change the only dev_vdbg() to dev_dbg().
drivers/misc/cb710/debug.c: In function 'cb710_read_regs_8': drivers/misc/cb710/debug.c:100: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' drivers/misc/cb710/debug.c: In function 'cb710_read_regs_16': drivers/misc/cb710/debug.c:101: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' drivers/misc/cb710/debug.c: In function 'cb710_read_regs_32': drivers/misc/cb710/debug.c:102: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' drivers/mmc/host/cb710-mmc.c: In function 'cb710_mmc_set_transfer_size': drivers/mmc/host/cb710-mmc.c:222: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' drivers/mmc/host/cb710-mmc.c:222: warning: format '%d' expects type 'int', but argument 6 has type 'size_t'
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
diff -urpN test2/drivers/misc/cb710/debug.c test3/drivers/misc/cb710/debug.c --- test2/drivers/misc/cb710/debug.c 2009-06-04 10:53:34.000000000 +0200 +++ test3/drivers/misc/cb710/debug.c 2009-06-05 11:22:38.000000000 +0200 @@ -37,7 +37,7 @@ static void cb710_read_regs_##t(void __i unsigned i, j; \ \ for (i = 0; i < ARRAY_SIZE(allow); ++i, reg += 16/(t/8)) { \ - if (!select & (1 << i)) \ + if (!(select & (1 << i))) \ continue; \ \ for (j = 0; j < 0x10/(t/8); ++j) { \ diff -urpN test2/drivers/mmc/host/cb710-mmc.c test3/drivers/mmc/host/cb710-mmc.c --- test2/drivers/mmc/host/cb710-mmc.c 2009-06-04 10:53:34.000000000 +0200 +++ test3/drivers/mmc/host/cb710-mmc.c 2009-06-05 11:22:39.000000000 +0200 @@ -219,7 +219,7 @@ static void cb710_mmc_set_transfer_size( cb710_write_port_32(slot, CB710_MMC_TRANSFER_SIZE_PORT, ((count - 1) << 16)|(blocksize - 1)); - dev_vdbg(cb710_slot_dev(slot), "set up for %d block%s of %d bytes\n", + dev_dbg(cb710_slot_dev(slot), "set up for %Zu block%s of %Zu bytes\n", count, count == 1 ? "" : "s", blocksize); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |