Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [Patch] kbuild: fix headers_check.pl | Date | Fri, 5 Jun 2009 10:21:50 +0100 |
| |
On Friday 05 June 2009, Amerigo Wang wrote: > -sub check_prototypes > +sub check_declarations > { > - if ($line =~ m/^\s*extern\b/) { > - printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; > + if ($line =~m/^\s*extern\b/) { > + if ($line =~ m/^\s*extern\b.*\(.*\)/) { > + printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; > + } else { > + printf STDERR "$filename:$lineno: exporting global variable to userspace is suspicious\n"; > + } > } > }
I don't think we really need that distinction here, the old text applies to both. But please find a way to get rid of the "extern's".
http://angryflower.com/bobsqu.gif
Arnd <><
| |