lkml.org 
[lkml]   [2009]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] gpio sysfs: add a "toggle" value
    From
    On Thu, Jun 4, 2009 at 03:54, Andrew Morton wrote:
    > On Wed,  3 Jun 2009 04:16:59 -0400 Mike Frysinger wrote:
    >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    >
    > -ENOCHANGELOGAGAIN

    it's pretty damned self explanatory

    >> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
    >> index 51a8d41..7f79732 100644
    >> --- a/drivers/gpio/gpiolib.c
    >> +++ b/drivers/gpio/gpiolib.c
    >> @@ -274,7 +274,12 @@ static ssize_t gpio_value_store(struct device *dev,
    >>       else {
    >>               long            value;
    >>
    >> -             status = strict_strtol(buf, 0, &value);
    >> +             if (sysfs_streq(buf, "toggle")) {
    >> +                     value = !gpio_get_value_cansleep(gpio);
    >> +                     status = 0;
    >> +             } else
    >> +                     status = strict_strtol(buf, 0, &value);
    >> +
    >>               if (status == 0) {
    >>                       gpio_set_value_cansleep(gpio, value != 0);
    >>                       status = size;
    >
    > A suitable place to document this is Documentation/gpio.txt.

    yes, but i wanted to make sure David didnt reject the idea before i
    spend time writing documentation.
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-06-04 10:19    [W:0.026 / U:61.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site