Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v2] kmap_types: convert most arches to a single header file | Date | Thu, 4 Jun 2009 22:28:34 +0100 |
| |
On Thursday 04 June 2009, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > Subject: kmap_types: make most arches use generic header file > > Convert most arches (*except frv*) to use asm-generic/kmap_types.h. > Each arch still has its own kmap_types.h for customization if > needed (like frv). > > KM_FENCE is now controlled by CONFIG_HIGHMEM. > > Built on x86_64, i386, mips, sparc32, sparc64, > alpha, powerpc64, ia64, and m68k. > > Note: Removed KM_PTE2 from generic kmap_types.h file; it was defined > but not used by avr32.
Every change in here looks good to me now, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
Two questions though:
1. The patch still conflicts with mine from the asm-generic tree. Yours is better in multiple ways (cleans up all the archs, adds the necessary types for ppc and arm), so should I drop mine now? I guess I can also make my file identical to yours so independent of who gets in first, there should be a clean merge?
2. should the asm and powerpc bits go through the arch maintainer trees? I guess since they are slightly more than an obvious consolidation, at least an Ack from BenH and Russell would be appropriate.
Arnd <><
| |