Messages in this thread | | | Date | Thu, 4 Jun 2009 09:46:06 -0400 | From | "John W. Linville" <> | Subject | Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation |
| |
On Thu, Jun 04, 2009 at 03:16:34PM +0400, Dmitry Eremin-Solenikov wrote: > On Wed, Jun 03, 2009 at 05:32:14PM -0700, Andrew Morton wrote: > > On Mon, 1 Jun 2009 18:54:44 +0400 > > Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
> > > + switch (addr->addr_type) { > > > + case IEEE802154_ADDR_LONG: > > > + rtnl_lock(); > > > + dev = dev_getbyhwaddr(net, ARPHRD_IEEE802154, addr->hwaddr); > > > + if (dev) > > > + dev_hold(dev); > > > + rtnl_unlock(); > > > + break; > > > + case IEEE802154_ADDR_SHORT: > > > + if (addr->pan_id != 0xffff && addr->short_addr != IEEE802154_ADDR_UNDEF && addr->short_addr != 0xffff) { > > > + struct net_device *tmp; > > > + > > > + rtnl_lock(); > > > + > > > + for_each_netdev(net, tmp) { > > > + if (tmp->type == ARPHRD_IEEE802154) { > > > + if (IEEE802154_MLME_OPS(tmp)->get_pan_id(tmp) == addr->pan_id > > > + && IEEE802154_MLME_OPS(tmp)->get_short_addr(tmp) == addr->short_addr) { > > > > You must use very wide xterms :( > > ~120 chars in width :) We prefer to have a single code line split between > several screen lines, rather than split it manually in some weird places > just to justify width of 80 chars.
Hopefully you realize that many find this difficult to read -- I just can't spread my eyes far enough to comprehend the lines.
80 chars is not a hard limit, but it is a good goal. 120 is too wide.
John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.
| |