lkml.org 
[lkml]   [2009]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] add support for the TI VLYNQ bus
On Thu, 4 Jun 2009 12:52:18 +0200 Florian Fainelli <florian@openwrt.org> wrote:

> Le Tuesday 02 June 2009 07:08:54 Andrew Morton, vous avez __crit__:
> > On Mon, 1 Jun 2009 13:58:27 +0200 Florian Fainelli <florian@openwrt.org>
> wrote:
> > > This patch adds support for the TI VLYNQ high-speed,
> > > serial and packetized bus. This bus allows external
> > > devices to be connected to the System-on-Chip and
> > > appear in the main system memory just like any memory
> > > mapped peripheral. It is widely used in TI's networking
> > > and mutlimedia SoC, including the AR7 SoC.
> > >
> > >
> > > ...
> > >
> > > +struct vlynq_regs {
> > > + u32 revision;
> > > + u32 control;
> > > + u32 status;
> > > + u32 int_prio;
> > > + u32 int_status;
> > > + u32 int_pending;
> > > + u32 int_ptr;
> > > + u32 tx_offset;
> > > + struct vlynq_mapping rx_mapping[4];
> > > + u32 chip;
> > > + u32 autonego;
> > > + u32 unused[6];
> > > + u32 int_device[8];
> > > +};
> > > +
> > > +#define vlynq_reg_read(reg) readl(&(reg))
> > > +#define vlynq_reg_write(reg, val) writel(val, &(reg))
> >
> > grumble. These just make the code harder to follow. it'd be better to
> > open-code readl() and writel() at the callsites.
>
> I do not understand how to fix this. Would an inlined accessors be a better
> solution for you?

Just remove the accessors altogether. Each place where there is a call
to vlynq_reg_read(), replace that with a call to readl().

Unless there's a reason not to do this. For example, some hardware
might require a udelay(1) before each writel(), or some platforms might
want to use outl()/inl(). In cases like these, sure, standalone
functions are needed to handle them.

But if vlynq_reg_read() and vlynq_reg_write() will never do anything
apart from a bare readl()/writel() then let's just remove them
altogether, as they add nothing.



\
 
 \ /
  Last update: 2009-06-04 13:23    [W:0.044 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site