Messages in this thread | | | Date | Wed, 1 Jul 2009 08:54:37 +0800 | From | Amerigo Wang <> | Subject | Re: [PATCH] Fix the multithread program core thread message error |
| |
Hi, Hui.
On Tue, Jun 30, 2009 at 05:12:31PM +0800, Hui Zhu wrote: >Fix the multithread program core thread message error. >The thread message of core file is generated in >elf_dump_thread_status. The register values is set by >elf_core_copy_task_regs in this function. >static inline int elf_core_copy_task_regs(struct task_struct *t, > elf_gregset_t* elfregs) >{ > > return ELF_CORE_COPY_TASK_REGS(t, elfregs); > return 0; >} >If a arch doesn't define ELF_CORE_COPY_TASK_REGS, This function will do >nothing. Then the core file will not have the register message of >thread. >So add elf_core_copy_regs to set regiser values if >ELF_CORE_COPY_TASK_REGS doesn't define.
You forgot your Signed-off-by line. :)
Hmmm, this patch looks sane for me. But could you please send us your test program? i.e. how did you test this?
Thank you!
>--- > elfcore.h | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/include/linux/elfcore.h b/include/linux/elfcore.h >index 7605c5e..03ec167 100644 >--- a/include/linux/elfcore.h >+++ b/include/linux/elfcore.h >@@ -125,6 +125,8 @@ static inline int elf_core_copy_task_regs(struct >task_struct *t, elf_gregset_t* > #ifdef ELF_CORE_COPY_TASK_REGS > > return ELF_CORE_COPY_TASK_REGS(t, elfregs); >+#else >+ elf_core_copy_regs(elfregs, task_pt_regs(t)); > #endif > return 0; > } >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/
| |