Messages in this thread Patch in this message | | | Date | Tue, 30 Jun 2009 17:13:59 -0700 | From | Greg KH <> | Subject | [patch 03/35] char: mxser, fix ISA board lookup |
| |
2.6.29-stable review patch. If anyone has any objections, please let us know.
------------------
From: Peter Botha <peterb@goldcircle.co.za>
commit 96050dfb25966612008dcea7d342e91fa01e993c upstream.
There's a bug in the mxser kernel module that still appears in the 2.6.29.4 kernel.
mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the not of the ioaddr, you're effectively passing 0 which means it won't be able to talk to an ISA card. I have tested this, and removing the ! fixes the problem.
Cc: "Peter Botha" <peterb@goldcircle.co.za> Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/char/mxser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -2712,7 +2712,7 @@ static int __init mxser_module_init(void continue; brd = &mxser_boards[m]; - retval = mxser_get_ISA_conf(!ioaddr[b], brd); + retval = mxser_get_ISA_conf(ioaddr[b], brd); if (retval <= 0) { brd->info = NULL; continue;
| |