Messages in this thread Patch in this message | | | Date | Tue, 30 Jun 2009 23:28:11 GMT | From | tip-bot for Anton Blanchard <> | Subject | [tip:perfcounters/urgent] perf top: Move skip symbols to an array |
| |
Commit-ID: 2ab52083ffc057014e502cf3473adc41436922fa Gitweb: http://git.kernel.org/tip/2ab52083ffc057014e502cf3473adc41436922fa Author: Anton Blanchard <anton@samba.org> AuthorDate: Wed, 1 Jul 2009 09:00:46 +1000 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Wed, 1 Jul 2009 01:25:19 +0200
perf top: Move skip symbols to an array
Move the list of symbols we skip into an array, making it easier to add new ones.
Signed-off-by: Anton Blanchard <anton@samba.org> Cc: a.p.zijlstra@chello.nl Cc: paulus@samba.org LKML-Reference: <20090630230140.904782938@samba.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- tools/perf/builtin-top.c | 24 +++++++++++++++++------- 1 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 5c29655..731ec6d 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -286,11 +286,22 @@ static void *display_thread(void *arg) return NULL; } +/* Tag samples to be skipped. */ +char *skip_symbols[] = { + "default_idle", + "cpu_idle", + "enter_idle", + "exit_idle", + "mwait_idle", + NULL +}; + static int symbol_filter(struct dso *self, struct symbol *sym) { static int filter_match; struct sym_entry *syme; const char *name = sym->name; + int i; if (!strcmp(name, "_text") || !strcmp(name, "_etext") || @@ -302,13 +313,12 @@ static int symbol_filter(struct dso *self, struct symbol *sym) return 1; syme = dso__sym_priv(self, sym); - /* Tag samples to be skipped. */ - if (!strcmp("default_idle", name) || - !strcmp("cpu_idle", name) || - !strcmp("enter_idle", name) || - !strcmp("exit_idle", name) || - !strcmp("mwait_idle", name)) - syme->skip = 1; + for (i = 0; skip_symbols[i]; i++) { + if (!strcmp(skip_symbols[i], name)) { + syme->skip = 1; + break; + } + } if (filter_match == 1) { filter_end = sym->start;
| |