lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] SFI: include/linux/sfi.h

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 23 Jun 2009 09:28:11 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> > > +/*
> > > + * Table structures must be byte-packed to match the SFI specification,
> > > + * as they are provided by the BIOS.
> > > + */
> > > +#pragma pack(1)
> >
> > We use __attribute__((packed)) for that generally.
>
> Or __packed. I usually recommend __packed because I can never
> remember the weird arrangement of underscores and parentheses in
> the gcc thing.

Agreed - it's also shorter and more in line with stuff like
__read_mostly, etc.

Ingo


\
 
 \ /
  Last update: 2009-07-01 00:03    [W:0.079 / U:2.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site