lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] FRV: Wire up new syscalls

* Arnd Bergmann <arnd@arndb.de> wrote:

> On Tuesday 30 June 2009, Ingo Molnar wrote:
> > * David Howells <dhowells@redhat.com> wrote:
> >
> > > Wire up new syscalls rt_tgsigqueueinfo and perf_counter_open.
> >
> > > + .long sys_perf_counter_open
> >
> > Hm, i suspect this should be sys_ni because FRV does not set
> > HAVE_PERF_COUNTERS so perfcounters cannot be enabled. (Or do you
> > have patches in the pipeline that enable perfcounters for FRV?)
>
> It doesn't matter because of the cond_syscall() in
> kernel/sys_ni.c. Right now, scripts/checksyscalls.sh causes a
> warning on each architecture that does not assign a system call
> number for sys_perf_counter_open, so they might as well make it
> point to sys_ni though cond_syscall().

It would make sense to wire it up for real as it's really easy: just
set HAVE_PERF_COUNTERS in arch/frv/Kconfig, add an empty
arch/frv/include/asm/perf_counter.h file. (Optional: double check
that tools/perf/ builds and works fine on FRV ;-)

Ingo


\
 
 \ /
  Last update: 2009-06-30 23:57    [W:0.079 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site