lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUGFIX][ PATCH] kprobes: fix kprobe selftest configuration dependency
On Mon, 22 Jun 2009 17:03:02 -0400
Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Select CONFIG_KALLSYMS_ALL when CONFIG_KPROBES_SANITY_TEST=y.
> Kprobe selftest always fail without CONFIG_KALLSYMS_ALL=y, because
> kallsyms doesn't list up the target functions which are probed in this
> test.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> ---
>
> lib/Kconfig.debug | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 23067ab..661c675 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -727,6 +727,7 @@ config KPROBES_SANITY_TEST
> bool "Kprobes sanity tests"
> depends on DEBUG_KERNEL
> depends on KPROBES
> + select KALLSYMS_ALL
> default n
> help
> This option provides for testing basic kprobes functionality on

KALLSYMS_ALL depends on KALLSYMS, so what happens here if KALLSYMS=n?

Ah, KPROBES depends on KALLSYMS, so that problem won't be occurring.

Still, the end result is significently more complex and fragile than a
`depends on' would have been. But I suppose we've done worse. Oh well.




\
 
 \ /
  Last update: 2009-06-30 23:41    [W:0.075 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site