lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86
Yinghai Lu wrote:
> H. Peter Anvin wrote:
>> Yinghai Lu wrote:
>>> agreed, that is why we change round_up to take u64.
>>>
>> round_up() is a macro, it doesn't "take" anything per se...
>>
> i mean
> end = roundup(start, ram_alignment(start)) - 1;
>
> static u64 ram_alignment(u64 pos)
>
> and other calling to round_up
>

This is fixing the wrong problem. Fixing round_up is the right thing,
not working around its brain damage.

-hpa


\
 
 \ /
  Last update: 2009-06-30 23:25    [W:0.091 / U:11.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site