lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 3/6][ARM] new ARM SoC support: BCMRing
On Tue, Jun 30, 2009 at 11:00:41AM +0530, Trilok Soni wrote:
> Hi Leo,
>
> > I'll fix the errors found by the checkpatch.pl script.  Is it okay to pass the checkpatch.pl with some warnings?
> >
>
> I don't think so, but if you find any false positives you can report to ML.

The answer is actually yes. For instance, if you have a prink where
the string you're printing goes over the 80 column limit, you have two
choices:

1. wrap the string. This is considered bad practice since it means
that you can't grep the kernel source for the exact message.

2. leave the string as is and ignore the checkpatch warning.

(2) is considered better practice than (1).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-06-30 23:15    [W:0.031 / U:8.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site