lkml.org 
[lkml]   [2009]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [KVM PATCH v5 0/2] iosignalfd
Gregory Haskins wrote:
> (Applies to kvm.git/master:25deed73)
>
> This is v5 of the series. For more details, please see the header to
> patch 2/2.
>
> This series has been tested against the kvm-eventfd unit test, and
> appears to be functioning properly. You can download this test here:
>
> ftp://ftp.novell.com/dev/ghaskins/kvm-eventfd.tar.bz2
>
> This series is ready to be considered for inclusion, pending any further
> review comments.
>

Sorry, Marcello. I re-used an old email when composing this. :)

Marcello, Avi, and myself have previously agreed that Marcello's
mmio-locking cleanup should go in first. When that happens, I will
need to rebase this series because it changes how you interface to the
io_bus code. I should have mentioned that here, but forgot. (Speaking
of, is there an ETA when that code will be merged Avi?)

That aside, after I sent this series I went to get some coffee to clear
my head and I thought of an issue in the code. I will reply inline to
patch 2/2.

-Greg

> [
> Changelog:
>
> v5:
> *) Removed "cookie" field, which was a misunderstanding on my
> part on what Avi wanted for a data-match feature
> *) Added a new "trigger" data-match feature which I think is
> much closer to what we need.
> *) We retain the dev_count field in the io_bus infrastructure
> and instead back-fill the array on removal.
> *) Various minor cleanups
> *) Rebased to kvm.git/master:25deed73
>
> v4:
> *) Fixed a bug in the original 2/4 where the PIT failure case
> would potentially leave the io_bus components registered.
> *) Condensed the v3 2/4 and 3/4 into one patch (2/2) since
> the patches became interdependent with the fix described above
> *) Rebased to kvm.git/master:74dfca0a
>
> v3:
> *) fixed patch 2/4 to handle error cases instead of BUG_ON
> *) implemented same HAVE_EVENTFD protection mechanism as
> irqfd to prevent compilation errors on unsupported arches
> *) completed testing
> *) rebased to kvm.git/master:7391a6d5
>
> v2:
> *) added optional data-matching capability (via cookie field)
> *) changed name from iofd to iosignalfd
> *) added io_bus unregister function
> *) implemented deassign feature
>
> v1:
> *) original release (integrated into irqfd v7 series as "iofd")
> ]
>
> ---
>
> Gregory Haskins (2):
> kvm: add iosignalfd support
> kvm: make io_bus interface more robust
>
>
> arch/x86/kvm/i8254.c | 22 +++
> arch/x86/kvm/i8259.c | 9 +
> arch/x86/kvm/x86.c | 1
> include/linux/kvm.h | 15 ++
> include/linux/kvm_host.h | 16 ++
> virt/kvm/coalesced_mmio.c | 8 +
> virt/kvm/eventfd.c | 356 +++++++++++++++++++++++++++++++++++++++++++++
> virt/kvm/ioapic.c | 9 +
> virt/kvm/kvm_main.c | 41 +++++
> 9 files changed, 462 insertions(+), 15 deletions(-)
>
>


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2009-06-03 23:41    [W:0.458 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site